Fix a bug in authorised values admin

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Previous change hid global search on results page too, fixing.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing some unused include files; Correcting nomenclature for cart; hiding quick search form on advanced search page; Styling user menu links as sidebar tabs.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor style tweak to lists menu; Trying to show public lists to non-logged-in users. Calling for help from atz.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Markup tweak for login; Link correction for facets.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

french translation updated

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

staged MARC import: handle non-ASCII characters in items

The problem occured during the population of
import_items.marcxml -- the MARC::Record object
created to store the item did not have the Leader/09
set to 'a', which means that MARC::File::XML
tried to transcode code the item from MARC-8 to UTF-8, which
breaks since the MARC data is already in UTF-8 at that point.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities: changed extension of authority-zebra-indexdefs.xml

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities: start of work on reindexing

Currently, MARC authorities are indexed (assuming Zebra
is used) with Zebra's GRS-1 module.  However, it does
not appear to be possible to index phrases that cross
subfield boundaries using the GRS-1 module's records.abs
config file's melm, elm, and xelm directives.

Since it is necessary to be able to efficiently search
an entire authority heading (e.g., to see if a given
bib heading is authorized), I'm proposing a switch
to Zebra's DOM XML filter module, which uses XSLT
to generate the words and phrases to be indexed from the
original MARC XML (or ISO2709) record.

The file authority-zebra-indexdefs.xml is an XSLT stylesheet
to implement the new indexing regime.  It is based on the
MARC21 authority record.abs with the following changes:

  * addition of 148/448/548
  * changed name of "see" indexes to "see-from"
  * changed name of "see-also" indexes to "see-also-from"
  * added index on the subject thesaurus based on
    the 008/11 and 040$f
  * added indexes on the full heading

authority-zebra-indexdefs.xml was generated from
authority-koha-indexdefs.xml via the XSL transform
koha-indexdefs-to-zebra.xsl.  authority-koha-indexdefs.xml
is the actual master version of the indexing definitions,
and was created to provide a much more compact syntax
over the raw XSLT that is to be passed to Zebra.

An experimental schema for Koha indexing definitions is
under way; my aim is to propose a simple format that can
be readily worked with, and perhaps even generated as
a serialization of indexing definitions that are set up
via administration settings in the Koha database itself.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Working version of cart and lists buttons, with some style changes to cart and lists popups. Bug: cart contents indicator conflicts with button-style js. Also adding new default button style.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More button tweaks

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More unfinished button style testing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More button style tests

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix for Bug 1790 - Correcting sysprefs opacthemes explanation to reflect current functionality

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug #1806

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix for Bug 1790: Theme defaults to prog if other themes fail.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

A couple of minor style tweaks.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing the way items are added to the cart and and lists from the searchresults page: Users now check items and choose from an 'add to...' dropdown which is populated with the logged-in user's lists. The add-to-shelf popup has been modified to accept a shelfnumber so that a users can add straight to the selected list.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Making the images show at admin/itemtype.spl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

OPAC bug fix: use correct index to limit by format

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug fixing : encoding with texts in opac-sendbasket.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

remove hardcoded link to opacsmallimage

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixes for cart functionality, including additions to update cart toolip window

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing "check all" function in search results; Using javascript to generate book bag and list buttons, since those functions depend on javascript being enabled.Also adding help.css, missing from yesterday's help file commits.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix to correct C4:Koha behavior which caused admin/itemtypes.pl to try to

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug in updatedatabase (extra comma) (fixed by Chris Nighswonger)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

minor db update changes for 2.2->3.0 script

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

syspref update to update22to30 script

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding manual datedue for renewals on moremember pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying functions for UNIMARC authors instead of function code

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding OpacHighlightedWords system preference

Disable or Enable the display of query terms in the biblio.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Button styling in masthead.inc is still conflicting with the js load() functions and the menu popup, so buttons are unstyled at the moment. Still need to integrate cart (basket/bookbag) functions.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More incremental changes to the OPAC masthead

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Updating yui/button.css to latest version, adding back in changes that eliminate the "body class="yui-skin-sam"" requirement

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Styling facets; correcting markup error in search results; removing language picker from opac-main (is now in the footer); continuing unfinished work on cart/lists buttons

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Enabling replacement of Koha logo with another image via opacsmallimage system pref; Adding some YUI files required by menus and popups

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Working on the language-picker menu in the footer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Unfinished: enabling language chooser in footer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Unstable changes to cart/list button interface in the OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Experimenting with styles for OPAC cart and lists button. Unfinished.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Beginning some design changes to the OPAC: put login info at the top, move cart and list buttons alongside main search form. Putting alternate search methods below the search form. These changes will eliminate the left-hand column from most OPAC screens.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Partial fix for Bug 1578: detect material type and don't load COinS unless the material type is known.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

retab, 4 chars, spaces

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

cleanup of opac-search.pl, synch with search.pl, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

mapping recordIdentifier to Koha internal ID

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Backend for "Session" Shelves in toolbar. Affects Auth and Context, so please test.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.pm - Clarify logout conditionals, debug messages. Die on failure of get_session("").

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

holidays.tmpl - format cleanup, CSS-ification, English corrections

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.pm - _session_log calls moved before undef of vars logged, LibraryName double => removed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing replace statement as per bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tidying up formatting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1790 Thanks to Chris Nighswonger

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1791

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug Fixing : Encoding in Z3950 searches

encoding is now defaulted to MARC8
encoding is now supported for USMARC and UNIMARC flavours.
Adding Encoding field to updatedatabase.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1772, thanks for the bug report Arona

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

basket.pl - bugfix 1714, GST pre-inclusion checked. FIXME's added.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Help for tools-home.pl added by Brooke

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1560

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix bug #1789 part 1

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting path to linked css and js

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

One more search button correction

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweaking display of search button in resident search form to address an issue described in Bug 1780.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding noItemTypeImages syspref to Auth.pm; Beginning the process of adding support for noItemTypeImages preference to intranet templtes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug, using branchcode instead of branch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1784,

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Debug - Centralized debug switches module, test and proof conversion (in Dates.pm)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying mobile or phonepro if no phone number.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding back the HomeorHoldingBranch syspref ... Dont Delete this is used by

Circulation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shifting HomeOrHoldingBranch to the circulation tab

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed permissions for updateitem

Per new bug 1783, it would be nice if editcatalogue would
work as well, but a change to the public API of C4::Auth
is needed for that to work.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more items work; handle unlinked subfields (DB rev => 048)

As a consequence, the items table now remains authoritative
for all item information: any subfields not explicitly mapped
in the framework are still stored.

In addition, the additional unlinked subfields are now retained
during a call to ModItem.

Two additional points of note:

* an upgrade script from 2.2 and earlier 3.0 instllations is needed
  to populate items.marc_subfields_xml; I am working on this.
* A behavour of bulkmarcimport.pl has now changed; any item subfields
  not explicitly mapped to a Koha items field were dropped; they are
  now retained and are stored in items.more_subfields_xml.  This can
  affect data migrations.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added caching of results of GetMarcStructure

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Items -- removed two warns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

editorial changes to C4/Items.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

prevent AddItem death if no marcrecord is given.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Important Commit For UNIMARC Items.

Nonetheless, you are right to consider items table as the reference.
We need one, and we agree on this principle.

What is done with this commit is :
- adding support for marc subfields not linked to items table.

+ removing some $dbh parameters in some function signature.
I think this is rel2_2 style programming and may be avoided using C4::Context->dbh.
Or there is a reason using dbh parameter that you know and not me.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bulkauthimport fix

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

correctly caluclate default template path for OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding dateexpiry to borrowers search result list

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1773, reading record not showing properly in the OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a few credits for translation team

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding changelanguage feature to OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moving a misplaced * to fix a bug in issuingrules

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Delete labels/label-select-pdf.pl - Cannot see where this was/is being used.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a bug that meant you had to have totals defined for

branch/itemtype/category in issuingrules, or TooMany would always fail

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1766 typo in sys pref explanation for dontmerge

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BugFixing : default language was always en. Not a problem for dev purpose but would be on installation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves wrap up - bugfix 1405, opac checkbox js fixed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BugFixing : 1299 /displaying lists for document types and borrower categories

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

sco.js - trivial javascript cleanup, comment

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves - bugfix 1403 amongst others

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying AuthorisedValues for items linked with authorised_value lists.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

displaying button Renew All only if syspref OpacRenewalAllowed is set.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding utf8 encoding for RSS.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Avoid double renew button when subscription is over

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding syspref PatronsPerPage

PatronsPerPage stores the number of patrons to display per page.
Default is 20

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1541, Show area name rather than number

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a broken redirect in the reports dictionary

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a bug where a cgi object wasnt being passed, in the reports dictionary

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Finishing off bug 1427, if the person has ReturnBeforeExpiry set they are

Signed-off-by: Joshua Ferraro <jmf@liblime.com>