item rework: moved various accessor functions

Moved following functions from C4::Biblio to
C4::Items:

    GetItemStatus
    GetItemLocation
    GetLostItems
    GetItemsForInventory
    GetItemsCount
    GetItemInfosOf
    GetItemsByBiblioitemnumber
    GetItemsInfo
    get_itemnumbers_of

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

staff results detail print: use itemcallnumber

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

labels item search: build item list correctly

Do not merge in a field mapped from the MARC biblio
if it already has been brought in from the item.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

OPAC detail print: use correct API to build item list

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

OPAC detail print: get call number from items.itemcallnumber

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed reports/inventory.pl

This had been moved to tools/ when 3.0 HEAD
was created, but the vestiges of the older
version had not been removed completely.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

item rework: replace direct SQL update of items

with ModItem calls

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

check for undefined values when mapping item to MARC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

inventory: two fixes

* Replaced direct "update items" with ModItem call
* fixed problem in template that prevent barcode file upload
  from working

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

item rework: POD and comments improvement

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

_replace_item_field_in_biblio now handles missing item field

If an item field with the appropriate itemnumber does not
exist in the MARC bib, the incoming item field is now
just added instead of being ignored.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed erroneous comment

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

item rework: moved GetItem

Moved from C4::Biblio to C4::Items.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

quell warning if updating itemnote whose original value is NULL

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

item rework: moved GetMarcItem

Moved this function from an exported function in
C4::Biblio to a public but unexported function
in C4::Items.  Added comment noting that this
is used only by additem.pl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

item rework: do not allow bulkedit to update items

This patch is meant to guarantee that a bulkedit
does not try to edit an item tag embedded in a MARC
biblio without updating the items feature.  It is
not a comprehensive fix of the bulkedit feature, which
currently does not appear to be functional and
needs some thought:

* The general search results is probably not the
  best place to put this feature -- it should
  probably be in tools.
* A bulk edit of something like items is desireable,
  but needs to be designed so that it respects
  business logic for circulation and acquisitions.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

item rework: moved ModItemInMarc

* Moved exported ModItemInMarc from C4::Biblio to
  C4::Items and renamed to _replace_item_field_in_biblio.
  Function is now private and is not exported, as
  ModItem is now the sole entry point for updating
  an item record.
* Replaced calls to ModItemInMarc in C4::Circulation
  with appropriate ModItem calls.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

items rework: fix several non-NULL columns during ModItem

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

start of BIB change -- introduce C4::Items

Introduced C4::Items module to separate items API
from biblio API.  Details on changes will be
put in later commit messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

DB rev 042: disallow null in aqbooksellers.name

Patch per Ryan Higgins; part of fix for bug 1251.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

DB rev 041: disallow NULL in some item status columns

notforloan, damaged, itemlost, wthdrawn

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing Database Definitions for Statuses *PARTIAL*

Prior to this fix, the status fields had three 'off' values, NULL, "",
and 0. I've reduced it to two in the db, removing the option for NULL, and
setting the default value to 0, however, we need to verify that we don't ever
write out as "" as this needlessly complicates the indexing process,
critical for searching or limiting by status (e.g., availability). Also,
queries that attempt to write a NULL value to one of these fields will fail
(based on my tests).

This patch includes the following changes:

* Updated the database definition for notforloan, damaged, itemlost, and
wthdrawn in kohastructure.sql to forbid NULL and default to 0; MySQL
can't forbid other values (such as empty ""), so this has to be handled
at the application layer and REQUIRES further patching.

* Fixed the 'limit by availability' query node in Search.pm to use a
much less confusing definition of 'available'

* Added code to set values to 0 where they are NULL or empty ( "" ) for
notforloan, damaged, itemlost or wthdrawn in both the MARC and the items
table:

  * Biblio.pm -> AddBiblioAndItems
  * catalogue/updateitem.pl
  * SEE NOTE BELOW, REQUIRES UPDATE TO THE REST OF KOHA'S ITEM MGT!

* Removed code in bulkmarcimport.pl that sets notforloan status depending
  on item-level or bib-level itemtype -- that flag is designed to be set
  only to override the notforloan setting for the item's (or bib's,
  depending on the syspref) assigned itemtype (it doesn't need to override
  to 'for loan', only to 'not for loan').

  added $dbh->do("truncate zebraqueue"); when operation is 'delete'

* I updated some notes in catalogue/updateitem.pl as to why ModItem can't be
used -- we don't have _a_ place where we can change the item and marc :/

  I've tested the following:

  bulkmarcimport.pl..........................MARC/items OK
  Staged Records Import......................NOT OK
  updateitem.pl (via moredetail.pl)..........MARC/items OK
  circulation.pl.............................NOT OK
  returns.pl.................................NOT OK
  addbiblio.pl...............................NOT OK
  additem.pl.................................NOT OK

Basically, there isn't a single place to apply this patch that will
update both item data and MARC data in one place ... a future patch
needs to address this issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Allow Library select on new bookfund and term update.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some tweaks for Debian Etch install procedure

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix Genre-form and Subject-topical for MARC21

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing a couple mappings for SRU CQL server

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/__DB_HOST__/__WEBSERVER_HOST__/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more tweaks for tmpl vars.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

tmpl var CATCODE_MULTI now passed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

now closes and redirects pop-up to parent , yay

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

tweaks to update-child feature.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

little fixes for update_child feature.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Improving searchhighlightblob, similar to Paul's patch:

1. doesn't remove author_nospan, and <span>s around bib fields for
display, perhaps they should just get a separate style?

2. using subfields now

3. improved ability to highlight small words (3 chars and less)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Making a start on online help for Acquisitions - Budget Based

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

upgrade-child 'Choose Adult category' popup-window now has resize.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding Online Help for Circ from Wiki (thanks tnb)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Escaping the $title in the regexes with \Q and \E to handle nested quantifiers

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Online help for admin, various tools and cataloguing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing "date due" column from holdings display, as date due is alread displayed in status column. Linking barcode link on detail.pl to named anchor on moredetail.pl (2.x feature).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Markup corrections and dialog formatting.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Formatting error message as standard dialog

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

A few minor markup corrections.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some refinements to statuses and messages. Beginning to standardize call number displays.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing dialogue when an item needs transferring adding Yes and No buttons

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

label-manager - POSIX unused, commented out

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

search.tmpl - layout fixes, TODO: handle empty submit w/o crashing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

label-manager.pl - purely whitespace edit, use git diff -U0 -w labels/label-manager.pl to verify

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

install.pl - exit after redirect

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

opac-detail.pl - cleanup incl. exit after redirect

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

small fix to french translation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

french translation updated

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing some spaces that are disliked by the translator

+ why is label-status.inc identified as a binary file on my station ?

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a searchhighlightblob style

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix : reintroduce author_nospan to have a cliquable author link everytime

without this, the <a href="q=au:author"> result in some <span> in the link

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

rebuild_zebra : directories updated

the unimarc stuff has been moved to marc_defs directory and the
lang specific is in lang_defs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

synch'ing marc21 and unimarc where applicable

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding OPACItemsResultsDisplay syspref (missing file from previous commit)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

NZSearch debugging

Adding NZoperatorAND NZoperatorOR NZoperatorNOT
Using NZOperatorAND NOT in NZanalyse
Some problem solved.

Please test.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

small fix to koha-conf.xml

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

padding Add_Delta_Days date, again.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUGFIX padding add_delta_days() date

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

WARNING: Updates to Index Defs for Authorities

This commit is a partial fix to authority control for MARC21,
and better authority handling in general (for UNIMARC too).
Before this patch, authority searching, editing, saving, was
not functioning, or was extremely buggy.

WARNING: You will need to re-index your authority database after
applying this commit.

The following changes have been made:

  * Normalizing record.abs index names (in both MARC21 and UNIMARC)
  * Synching authorities/bib1.att, ccl.properties, AuthoritiesMarc.pm
    with new indexes (UNIMARC too)
  * Clean up biblios/bib1.att (remove duplicate att defs)
  * Clean up authorities-* templates to conform to new styles
  * Fixed search failure when using Default framework (now searches
    All)

Also included are several fixes to the built-in SRU server for
Authority and Biblio, it's recommended that you update your
koha-conf.xml file:

  * adding explain-authorities.xml and explain-biblios.xml
  * adding necessary info to koha-conf.xml to enable SRU/W
  * adding several example XSLT stylesheets, that can be used
    for SRU on-the-fly transformations (to MODS, DC, RDF, etc.)

Still remaining for 3.0 are the following tasks:

  * update MARC21 frameworks (authority and cross-reference bib)
  * update display code/templates in authority results list
  * update search code/templates to utilize index points
  * implement 'grouping' of authtypes for searching (Name, Title, Subject)
  * repair utility to import auths and perform matching
  * repair bibliographic import to match auths and warn if no match

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

TransformHtmlToXml() now checks from UNIMARC flavour, before inserting encoding info to 100$a

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding release notes for 3.0

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1723. no auth on finishreceive.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

nomenclature cleanup for acquisitions:

supplier -> vendor
freight -> shipping
parcel -> shipment
shopping basket -> basket
parcel code -> invoice number

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix to redirect the user ot the select branch page if they try to use

circulation without a branch set

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix bug in ModReceiveOrder call

had been losing datereceived and replacementprice on modorder.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Specify datereceived when receiving a new parcel.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing extra collection display from moredetail.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding missing title info from MARC view / intranet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1711

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix for 1725 request.pl erroring with a biblio that has no items

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1251 (blank supplier name)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Further updates to acq, merging in dev_week mods.

Splitting orders now on receipt.
Many tmpl updates to pass correct values btwn scripts.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

add item-level location,collection fields to orderreceive

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

cleanup parcel.pl and tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updates to acqui - first of several commits

bug fixes to display and save publishercode and purchase order numbers.
use invoice number in place of parcel code
fix template apparently allowing user to modify biblio details on add/mod order
removing CGI scrolling_list

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/Waited/Expected/ for serials statuses reformating rebuild_nozebra.pl indexes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

NewsChannels - format_date for news "Posted on" date

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

systempreferences - remove dateformat from admin tab

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

opac-shevles - fix for CSS alternating highlight lines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

opac-shelves.tmpl cleanup - obsolete input removed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

opac-addbybiblionumber.pl - Remove false dependency, add body message in case scripts disabled.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing un-needed "yui-toolbars.inc" include

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1708

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1515

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Online help for catalgouing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing text from Virtual Shelves to Lists

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Online help for suggestions management

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to enable separate imageurls for item-level itypes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improving sample data for English

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating INSTALL and INSTALL.debian

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1319, can no longer delete an item with a waiting reserve on it

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1626, whitespace stripped from barcodes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1461, checkbox now doesnt display if you cant renew an item

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1552, fix ordering of issued items

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for item level itypes and toomany subroutine

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding README

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more re-arranging prior to release

Signed-off-by: Joshua Ferraro <jmf@liblime.com>