From 79bafa2aa84bcb135ebbbc98bf485356be37c98b Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Fri, 14 Jun 2019 10:43:15 +0200 Subject: [PATCH] Bug 22617: Fix checkout notes typo in manage_checkout_notes permission usage When logged into the staff client with an account with full circulate permissions (and therefore including the manage_checkout_notes permission) an error occurs when clicking on the Checkout notes pending link. The account is logged out automatically with the message: "Error: you do not have permission to view this page. Log in as a different user". The same error occurs for both the link on the home page dashboard and from the Circulation module button. Works as expected if Superlibrarian permission is set. This is just a typo in perl script : circulation instead of circulate Test plan : 1) Set preference "AllowCheckoutNotes" to "Allow" 2) Create a user with only permissions "catalogue" and "circulate > manage_checkout_notes" 3) Loggin with this user 4) Go to "Circulation" home page 5) Click on "Checkout notes" 6) You should be allowed to access Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 206498dc5585fbd555181a1b241d5049632870df) Signed-off-by: Fridolin Somers --- circ/checkout-notes.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/checkout-notes.pl b/circ/checkout-notes.pl index 97fb925977..324d15e65b 100755 --- a/circ/checkout-notes.pl +++ b/circ/checkout-notes.pl @@ -33,7 +33,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( query => $query, type => "intranet", authnotrequired => 0, - flagsrequired => { circulation => "manage_checkout_notes" }, + flagsrequired => { circulate => "manage_checkout_notes" }, } ); -- 2.39.5