From a6f538cbcd67303a8d7e8ff6f9ef79f68182649f Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Wed, 8 Jan 2020 12:48:55 +0000
Subject: [PATCH] Bug 24339: Remove SIP payment types from staff pay screens

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../prog/en/modules/members/boraccount.tt              |  5 ++++-
 .../prog/en/modules/members/paycollect.tt              | 10 ++++++++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
index 7427d41e38..4d7adbb41d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ -143,12 +143,15 @@
                                     <span class="required">Required</span>
                                 </li>
                                 [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %]
-                                [% IF payment_types %]
+                                [% SET excluded = ['SIP00', 'SIP01', 'SIP02'] %]
+                                [% IF payment_types > 3 %]
                                 <li>
                                     <label for="transaction_type">Transaction type: </label>
                                     <select name="transaction_type" id="transaction_type">
                                         [% FOREACH pt IN payment_types %]
+                                            [% UNLESS excluded.grep("^$pt.authorised_value\$").size %]
                                             <option value="[% pt.authorised_value | html %]">[% pt.lib | html %]</option>
+                                            [% END %]
                                         [% END %]
                                     </select>
                                 </li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
index fa358135e6..61220f1584 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ -124,13 +124,16 @@
         <span id="change">0.00</span>
     </li>
     [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %]
-    [% IF payment_types %]
+    [% SET excluded = ['SIP00', 'SIP01', 'SIP02'] %]
+    [% IF payment_types.size > 3 %]
         <li>
             <label for="payment_type">Payment type: </label>
             <select name="payment_type" id="payment_type">
                 <option value=""></option>
                 [% FOREACH pt IN payment_types %]
+                    [% UNLESS excluded.grep("^$pt.authorised_value\$").size %]
                     <option value="[% pt.authorised_value | html %]">[% pt.lib | html %]</option>
+                    [% END %]
                 [% END %]
             </select>
         </li>
@@ -254,13 +257,16 @@
             <span id="change">0.00</span>
         </li>
     [% SET payment_types = AuthorisedValues.GetAuthValueDropbox('PAYMENT_TYPE') %]
-    [% IF payment_types %]
+    [% SET excluded = ['SIP00', 'SIP01', 'SIP02'] %]
+    [% IF payment_types.size > 3 %]
         <li>
             <label for="payment_type">Payment type: </label>
             <select name="payment_type" id="payment_type">
                 <option value=""></option>
                 [% FOREACH pt IN payment_types %]
+                    [% UNLESS excluded.grep("^$pt.authorised_value\$").size %]
                     <option value="[% pt.authorised_value | html %]">[% pt.lib | html %]</option>
+                    [% END %]
                 [% END %]
             </select>
         </li>
-- 
2.39.5