From c44bfe12087cda33b351b157014e818db2e4613a Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 27 Feb 2020 02:06:34 +0000
Subject: [PATCH] Bug 24746: Duplicate id in opacheader markup

This patch removes '<div id="opacheader">' from masthead.inc
because the same markup is generated by koha_news_block.

To reproduce the bug, make sure there is an opacheader news block
defined. Add this to the OPACUserCSS system preference:

View the main page of the OPAC. You should see two blue borders around
the opacheader content.

Apply the patch and reload the OPAC page. There should now be only one
blue border.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Tested whith OPACUserCSS -> #opacheader { border: 1px solid blue; padding: 1px; }
don't know the intended value but works :)

Work as described following test plan, no errors.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
index cef392338a..a27be4d487 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
@@ -150,9 +150,7 @@
         [% IF ( OpacHeader ) %]
             <div class="container-fluid">
                 <div class="row-fluid">
-                    <div id="opacheader">
-                        [% PROCESS koha_news_block news => OpacHeader %]
-                    </div>
+                    [% PROCESS koha_news_block news => OpacHeader %]
                 </div>
             </div>
         [% END %]
-- 
2.39.5