From cc86857dd642e9c5a53012f005dd59899bc2cb0d Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 5 Dec 2013 09:13:35 -0500
Subject: [PATCH] Bug 11342: fix error in OPAC self registration form if
 BorrowersTitles is empty

If BorrowersTitles is empty, it causes the library pulldown on the self
registration page to be empty, and to have the "Saluation" field have
the option "branches".

This patch also fixes a minor string capitalization issue.

Test Plan:
1) Enable OPAC self registration
2) Set the system preference BorrowersTitles to be empty
3) View the self registration page
4) Note the lack of branches in the home library pulldown
5) Apply this patch
6) Note the branches now display in the pulldown

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested in bootstrap and prog OPAC, with BorrowersTitle configured
and emptied.
Passes all tests and QA script.

Note: The titles pull down has 2 empty entries in master with
and without the patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 9a5f737dcbb1c695130a3acafd46a63a44f2e4cf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 4 ++--
 koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt      | 4 ++--
 opac/opac-memberentry.pl                                     | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
index a82380a177..0d48e8dd29 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
@@ -68,7 +68,7 @@
                                         [% ELSE %]
                                             <label for="borrower_branchcode">
                                         [% END %]
-                                        Home Library:</label>
+                                        Home library:</label>
 
                                         <select id="borrower_branchcode" name="borrower_branchcode">
                                             [% FOREACH b IN branches %]
@@ -100,7 +100,7 @@
                                 <legend id="identity_legend">Identity</legend>
 
                                 <ol>
-                                    [% UNLESS hidden.defined('title') %]
+                                    [% UNLESS hidden.defined('title') || !member_titles %]
                                         <li>
                                             [% IF mandatory.defined('title') %]
                                                 <label for="borrower_title" class="required">
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt
index 5b86268381..215d8cb71e 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt
@@ -77,7 +77,7 @@
                                                     [% ELSE %]
                                                         <label for="borrower_branchcode">
                                                     [% END %]
-                                                    Home Library:</label>
+                                                    Home library:</label>
 
                                                     <select id="borrower_branchcode" name="borrower_branchcode">
                                                         [% FOREACH b IN branches %]
@@ -107,7 +107,7 @@
                                         <legend id="identity_legend">Identity</legend>
 
                                         <ol>
-                                            [% UNLESS hidden.defined('title') %]
+                                            [% UNLESS hidden.defined('title') || !member_titles %]
                                                 <li>
                                                     [% IF mandatory.defined('title') %]
                                                         <label for="borrower_title" class="required">
diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
index 143e3167c1..76fd32b453 100755
--- a/opac/opac-memberentry.pl
+++ b/opac/opac-memberentry.pl
@@ -60,7 +60,7 @@ $template->param(
     action            => $action,
     hidden            => GetHiddenFields(),
     mandatory         => GetMandatoryFields($action),
-    member_titles     => GetTitles(),
+    member_titles     => GetTitles() || undef,
     branches          => GetBranchesLoop(),
     OPACPatronDetails => C4::Context->preference('OPACPatronDetails'),
 );
-- 
2.39.5