From d284735d05f67226feba1b4b9e7bf17259eaabaf Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 3 Jun 2021 07:29:52 -0400 Subject: [PATCH] Bug 28510: Remove unnecessary conditional It makes sense to use items by branch to get the list of branches, as it already tells use which branches have available items. We could use branches to pull from instead, but all we would accomplish is added extra ununsed loop iterations. We already know that any additional branches in the branches to pull loop have no items to fill holds. If they did, they would be in the items_by_branch hash. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart --- C4/HoldsQueue.pm | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm index b4d2b026f2..b61562885f 100644 --- a/C4/HoldsQueue.pm +++ b/C4/HoldsQueue.pm @@ -596,12 +596,7 @@ sub MapItemsToHoldRequests { } unless ($itemnumber) { - # not found yet, fall back to basics - if ($branches_to_use) { - $pull_branches = $branches_to_use; - } else { - $pull_branches = [keys %items_by_branch]; - } + $pull_branches = [keys %items_by_branch]; # Try picking items where the home and pickup branch match first PULL_BRANCHES: -- 2.39.5