]> git.koha-community.org Git - koha.git/commit
Bug 6877 - use is executed and errors at compile time
authorColin Campbell <colin.campbell@ptfs-europe.com>
Sat, 17 Sep 2011 11:45:09 +0000 (12:45 +0100)
committerChris Nighswonger <chris.nighswonger@gmail.com>
Fri, 2 Dec 2011 19:53:23 +0000 (14:53 -0500)
commit05ba6867ccffc3b8673f6a69a2370d979a60d324
treed09828dd44e325bc86079929feb813a6fdf2a782
parent989656fe82c43d415780dad40a2d7361a1f3971b
Bug 6877 - use is executed and errors at compile time

Although use is being called in an eval it will still be executed
at compile time so that an error can cause the script to abort before
the eval is executed. The eval expression syntax is not checked
so eval block should be preferred.
Use require/import which execute at runtime which is the intention
here.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
checked that, with Libravatar OK things are still OK
(cherry picked from commit 4f49dc5ad05289820916c6fd879e70f3adeee253)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
opac/opac-detail.pl
opac/opac-showreviews.pl