]> git.koha-community.org Git - koha.git/commit
Bug 18996: [16.11.x] [QA Follow-up] Remove global variables from Message.t
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 2 Aug 2017 11:01:47 +0000 (13:01 +0200)
committerKatrin Fischer <katrin.fischer.83@web.de>
Fri, 15 Sep 2017 22:49:07 +0000 (00:49 +0200)
commit099897fd2738e4589f9e8412be242ccf000fcb69
treeaba4777a41ecf586c545f7a197c8aae8156e1f81
parent255dca62aa5f3989a981b493774517f8f53d01cb
Bug 18996: [16.11.x] [QA Follow-up] Remove global variables from Message.t

As per request of Colin in comment18, this patch makes the use of global
variables in Message.t no longer needed.
The three subtests are now completely independent and could well be moved
to separate test scripts.

Note: Strictly speaking, the use of global (package) variables could
potentially introduce new bugs (e.g. if the value is modified outside the
script). This seems not to be the case here, but we are safe now.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/SIP/Message.t