]> git.koha-community.org Git - koha.git/commit
Bug 31497: Prevent ID clash on quick add fields
authorNick Clemens <nick@bywatersolutions.com>
Tue, 13 Sep 2022 12:19:57 +0000 (12:19 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Thu, 22 Sep 2022 11:02:40 +0000 (08:02 -0300)
commit0f599e2a2a8c9f6caed4fe4ae6060b106d2a1004
treef3feb5369505a052e379bd279da001fee5fca4ab
parentb1e3398e84674f443d1b3c348058e45291f45e8e
Bug 31497: Prevent ID clash on quick add fields

The quick add clones the original fields, including ids. This can cause some clash when
other JS is running on the page.

This patch updates the ids of the fields before adding to the form, which prevents bad
copying/clearing of fields

To test:
* Go to patrons module
* Click on Quick add new patron (I chose Patron as category)
* On sample database these fields are marked as mandatory:
  * Surname
  * Cardnumber
  * Library
  * Category
* Fill in Surname, leave cardnumber empty
* Save - mandatory message is shown
* Fill in cardnumber - save
* The patron is saved
* BUT: cardnumber is empty!
APPLY PATCH
* Repeat plan above
* Cardnumber is correctly saved

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt