]> git.koha-community.org Git - koha.git/commit
Bug 18996: [16.11.x] [QA Follow-up] Remove global variables from Message.t
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 2 Aug 2017 11:01:47 +0000 (13:01 +0200)
committerMason James <mtj@kohaaloha.com>
Wed, 20 Sep 2017 02:00:02 +0000 (14:00 +1200)
commit29260299c314bee90980f105baa345072fc35f84
treed9843975f71dacb4ca2837cae5bd5846cdc9339a
parent40e2970eeebdc8b05ea10b7e0159faa2a3fa80bc
Bug 18996: [16.11.x] [QA Follow-up] Remove global variables from Message.t

As per request of Colin in comment18, this patch makes the use of global
variables in Message.t no longer needed.
The three subtests are now completely independent and could well be moved
to separate test scripts.

Note: Strictly speaking, the use of global (package) variables could
potentially introduce new bugs (e.g. if the value is modified outside the
script). This seems not to be the case here, but we are safe now.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Conflicts:
t/db_dependent/SIP/Message.t
t/db_dependent/SIP/Message.t