]> git.koha-community.org Git - koha.git/commit
Bug 20783: Use iframe to embed Youtube videos
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 12 May 2020 10:54:50 +0000 (12:54 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 15 Jun 2020 08:32:43 +0000 (10:32 +0200)
commit2d7e08bc0e8c1ab6f21cce06932bb7dd6660cfcd
treea94ddd36ba9ae71dea5f7e00b2abf9b8dbecc677
parent6fc316d2eef5945b20a14bec81e2daa57696dd81
Bug 20783: Use iframe to embed Youtube videos

WWW::YouTube::Download is broken and not reliable.
Other alternative was to use HTML::Video::Embed but not updated since
years.

The best alternative seems to follow youtube advise and use an iframe
https://developers.google.com/youtube/iframe_api_reference

Test plan:
Put youtube video in 856$u (using different url formats, youtu.be,
youtube.com/embed, etc.)
Enable HTML5MediaEnabled and HTML5MediaYouTube and confirm that the
youtube videos are correctly embeded.

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/HTML5Media.pm
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt