]> git.koha-community.org Git - koha.git/commit
Bug 20427: Convert OPAC LESS to SCSS
authorOwen Leonard <oleonard@myacpl.org>
Thu, 15 Mar 2018 16:14:09 +0000 (16:14 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 9 Aug 2018 15:17:07 +0000 (15:17 +0000)
commit2df87a94f5bcd538799b8684139525d79d8c0af5
treee8011cd17078fb03b1ca583e216c3dc3c37bd69d
parent574bc788ab23e554c05742a4f0affabe671993e6
Bug 20427: Convert OPAC LESS to SCSS

This patch converts the OPAC LESS files to SCSS. In the process of
converting opac.less (and other .less files) to .scss, I have improved
the completeness of the nesting, reordered properties, and in general
done cleanup based on rules in .scss-lint.yml. All of these changes
should have no impact on the style of the OPAC.

This patch modifies the commands used to compile CSS so that OPAC and
staff assets can be processed separately:

'yarn build' <-- Builds the staff client assets by default
'yarn build --view opac' <-- Builds OPAC assets

To test, apply the patch and compile the CSS by running the command
above (or apply the follow-up patch with compiled CSS).

Do a thorough review of the OPAC, taking care to cover as many pages as
possible and checking responsive behavior at the same time. There should
be no visual differences in the OPAC before and after applying the
patch.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
13 files changed:
.gitignore
.scss-lint.yml [new file with mode: 0644]
gulpfile.js
koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/css/src/print.scss [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/css/src/right-to-left.scss [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/less/mixins.less [deleted file]
koha-tmpl/opac-tmpl/bootstrap/less/opac.less [deleted file]
koha-tmpl/opac-tmpl/bootstrap/less/print.less [deleted file]
koha-tmpl/opac-tmpl/bootstrap/less/responsive.less [deleted file]
koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.less [deleted file]