]> git.koha-community.org Git - koha.git/commit
Bug 18349: SCO - Do not trust the confirmed flag
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 29 Mar 2017 21:25:40 +0000 (18:25 -0300)
committerMason James <mtj@kohaaloha.com>
Sun, 30 Apr 2017 11:19:54 +0000 (23:19 +1200)
commit42741c2689e5cad1c1b2d11fa303b60d5fff25e4
tree63e5a894fb9f4b9c221f18c160aabeb1e3fa724d
parenta6f9a0a529c9df6749cb2cabb1f6c2b2d9869fe9
Bug 18349: SCO - Do not trust the confirmed flag

The "confirmed" flag is used to know if that user confirmed a situation
that needs a confirmation.
But if the issue/renew is impossible the CanBookBeIssued and the
'impossible flags' should be checked.

Otherwise a patron can checkout and renew bypassing the circulation
rules (Understand 'no limit' here...)

Test plan:
Want to renew?
Checkin $barcode, then
/cgi-bin/koha/sco/sco-main.pl?patronid=$cardnumber&barcode=$barcode&confirmed=1&op=checkout

Want to bypass the checkin?
Same url...

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 85bd15a83ffdab0c2e28eae54e50ce4dee9e608b)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Conflicts:
opac/sco/sco-main.pl
opac/sco/sco-main.pl