]> git.koha-community.org Git - koha.git/commit
Bug 33622: Notice content does not show on default tab if TranslateNotices enabled
authorOwen Leonard <oleonard@myacpl.org>
Tue, 2 May 2023 17:24:08 +0000 (17:24 +0000)
committerMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Mon, 15 May 2023 12:08:42 +0000 (12:08 +0000)
commit4aa36507f488122010858dc1b2e9696324dd3612
tree6aff67ce8131dc05a71410bf864fb0ed7d2fd46a
parentbe7df5dc0db7d02597ddeec2899a17fb63613536
Bug 33622: Notice content does not show on default tab if TranslateNotices enabled

This patch fixes a conflict between the template-generated markup and
Bootstrap JS which were both competing to show the correct default tab.
It's simpler to rely on JavaScript.

To test, apply the patch and enable the TranslateNotices system
preference if necessary.

- Go to Tools -> Notices & slips
- Go to edit any notice e.g. DUEDGST
- The page should load with the "Default" tab selected by default.
- Enter unique titles and contents under each tab to confirm that the
  data you see under the "Default" or "English (en)" tab is being shown
  in the right place.
- Save your modified notice and edit it again to confirm that the tabs
  correspond correctly to your data.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 1e5c55176ef4d70b1535040a576ab13d4561c53f)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
koha-tmpl/intranet-tmpl/prog/js/letter.js