]> git.koha-community.org Git - koha.git/commit
Bug 15629: Koha::Libraries - Remove GetBranchDetail
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 20 Jan 2016 12:17:43 +0000 (12:17 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Wed, 24 Feb 2016 03:55:06 +0000 (03:55 +0000)
commit4f5217314cefded2aaa82e9bda0dd1ce6d81a88e
tree27b55eb67ed2d74f13710ad3da731398c5e16b31
parentf4d6c1cd50702011d72ac8cea76065fe319588ba
Bug 15629: Koha::Libraries - Remove GetBranchDetail

C4::Branch::GetBranchDetail retrieved library infos, it could be easily
replaced with Koha::Libraries->find

When this change needs other big changes, the unblessed method is
called, to manipulate a hashref (as before) instead of a Koha::Library
object (for instance when $library is sent to GetPreparedLetter).

Test plan:
1/ Print a basket group, the library names should be correctly
displayed.
2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED
notice will be generated (focus on the library name)
3/ Edit a patron and change his/her library
4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and
have a look at the generated notices
5/ Same of overdues notices
6/ Set IndependentBranches and use a non superlibrarian user to place a
hold. The "pickup at" should be correctly filled.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
22 files changed:
C4/Acquisition.pm
C4/Branch.pm
C4/Circulation.pm
C4/Letters.pm
C4/Reserves.pm
acqui/addorderiso2709.pl
acqui/pdfformat/layout2pages.pm
acqui/pdfformat/layout2pagesde.pm
acqui/pdfformat/layout3pages.pm
acqui/pdfformat/layout3pagesfr.pm
catalogue/ISBDdetail.pl
members/members-home.pl
members/moremember.pl
misc/cronjobs/advance_notices.pl
misc/cronjobs/notice_unprocessed_suggestions.pl
misc/cronjobs/overdue_notices.pl
reserve/request.pl
t/db_dependent/Branch.t
t/db_dependent/ILSDI_Services.t
t/db_dependent/Items.t
t/db_dependent/Letters.t
t/db_dependent/Suggestions.t