]> git.koha-community.org Git - koha.git/commit
Bug 18996: [16.11.x] Resolve an uninitialized warning from ILS/Item.pm
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 1 Aug 2017 12:10:56 +0000 (14:10 +0200)
committerMason James <mtj@kohaaloha.com>
Wed, 20 Sep 2017 02:00:01 +0000 (14:00 +1200)
commit6977e2200daa8f1a8cf7dd6d2bf2650ee346d313
tree48a52f2c83847b24fa31a2a17577b6bdf341d243
parent722c26c4ef16074624f0606233a1671509289bd6
Bug 18996: [16.11.x] Resolve an uninitialized warning from ILS/Item.pm

From the syslog call on line 107/108. The field $item->{title} has not
been initialized. When catching the warns in a test script with Test::Warn,
I got:
    Use of uninitialized value $args[1] in sprintf at /usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423.

This simply resolves the warning. We might have a closer look to this title
field on another report though.

Test plan:
Run Message.t from the next patch without this fix. It will fail since the
additional warning makes warnings_like return false.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/SIP/ILS/Item.pm