]> git.koha-community.org Git - koha.git/commit
Bug 30822: Clarify that BatchCommitItems is a private function
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 26 May 2022 12:03:10 +0000 (13:03 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 22 Jun 2022 12:43:53 +0000 (09:43 -0300)
commit7a7bee59021728a30c631e2ee51f9b7778217a9f
tree6a5a9bb359187e5195d96c0bb902efaebeaf9da3
parent809b6e701691118bbd1589428abc6fd1bada4b8c
Bug 30822: Clarify that BatchCommitItems is a private function

BatchCommitItems is only being used within this module and isn't
mentioned in EXPORT_OK. This patch simply renames it to
_batchCommitItems to take the _ standard for private functions and also
adds a little hint to the POD of the function to clarify that the caller
must trigger a re-index.

JK: Amended patch to rename also the function in t/db_dependent/ImportBatch.t
    and fix typo "commiting" => "commiting"

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/ImportBatch.pm
t/db_dependent/ImportBatch.t