]> git.koha-community.org Git - koha.git/commit
Bug 8246: Allow deleting record if no more items
authorJonathan Druart <jonathan.druart@biblibre.com>
Tue, 31 Mar 2015 14:32:33 +0000 (16:32 +0200)
committerChris Cormack <chris@bigballofwax.co.nz>
Sat, 11 Apr 2015 05:30:42 +0000 (17:30 +1200)
commitb8348370afe2c35b32df2b4247c0c9d13c4bb8e4
treebc44971c47d0a0f2c3e713e561829ad862ca139a
parent7e8fef025451e68604e67b5f5ca145fd526fee5f
Bug 8246: Allow deleting record if no more items

The "Delete records if no items remain" was only available if the batch
did not contain "too many" items (see MaxItemsForBatch).
This limitation does not make any sense.

Test plan:
1/ Set MaxItemsForBatch=10
2/ Use the batch item deletion to delete 10+ items
3/ Confirm the checkbox "Delete records if no items remain" is displayed
4/ Check it
5/ Launch the job
6/ Run koha qa test tools

Verify that the records without items have been deleted also.

NOTE: My test db only had two biblios with items, so I set
      MaxItemsForBatch=1.
      Before patch, checkbox did not display.
      After patch, checkbox did display.
      This patch merely moves one line out of the IF/ELSE/END
      block, and reindents for more readability. Though, there
      is a missing <p> if you want to get picky.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 2a8f84817fb4a487577c7e4238b8aede9d9b99d2)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt