]> git.koha-community.org Git - koha.git/commit
Bug 18697: Final polishing
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 31 May 2017 14:19:35 +0000 (16:19 +0200)
committerMason James <mtj@kohaaloha.com>
Sun, 30 Jul 2017 13:02:07 +0000 (01:02 +1200)
commitbc3ecf72b375ace1dc9376d2d8e0a8158894ddf6
tree78ec7a404f1cde658333b4df0f1e2f0fbd871e33
parent6b153585bf97b66d2f59b1d49e5fe720d483399c
Bug 18697: Final polishing

GetFictiveIssueNumber:
Returns undef instead of 0 for irregular frequencies. Also added to POD.
Removed unused variable $wkno.
Adding a return makes the if(unit) unneeded.
Replaced (a+b)/b by 1+a/b.

_delta_units:
Added a comment about its parameters.

GetFictiveIssueNumber.t:
Adjusted the tests for irregular frequencies accordingly.

Test plan:
[1] Run t/db_dependent/Serials/GetFictiveIssueNumber.t
[2] Run t/db_dependent/Serials/GetNextDate.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
C4/Serials.pm
t/db_dependent/Serials/GetFictiveIssueNumber.t