]> git.koha-community.org Git - koha.git/commit
Bug 21704: Edit framework subfield link is broken (TT filter)
authorTomas Cohen Arazi <tomascohen@theke.io>
Sun, 28 Oct 2018 12:36:32 +0000 (09:36 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 29 Oct 2018 00:17:33 +0000 (00:17 +0000)
commite7c049fea753232a51d78e07a9f15354cd71a469
tree6e86a0a15f867fa860d64204aad2da3335e7963e
parent5c5ecedb3f1cfed8d97ba837bfa98427d4a6ec5e
Bug 21704: Edit framework subfield link is broken (TT filter)

This patch removes URL building from the controller
(admin/marctagstructure.pl) and does it on the templates, using the
right 'uri' filter for the query parameters.

It also removes:
- No longer used attributes that are passed to the template
- Duplicated code in the templates

To test:
- Go to Home > Administration > MARC bibliographic framework
- On any of the listed frameworks, pick the 'MARC structure' action in
the dropdown
- On any subfield, hover on the actions dropdown
=> FAIL: The URLs are wrongly formed
- Click on the links
=> FAIL: You get errors because of the bad URL
- Apply this patch
- Reload the 'MARC structure' page
- On any subfield, hover on the actions dropdown
=> SUCCESS: LInks look correct
- Click on any of them
=> SUCCESS: They work!
- Use the 'Display only used tags/subfields' checkbox
=> SUCCESS: No behaviour change!
- Sign off :-D

Sponsored-by: Theke Solutions
Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
admin/marctagstructure.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt