]> git.koha-community.org Git - koha.git/commit
Bug 29679: Remove redundant divider element from reports menu
authorOwen Leonard <oleonard@myacpl.org>
Mon, 13 Dec 2021 12:16:06 +0000 (12:16 +0000)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 17 Dec 2021 14:55:04 +0000 (09:55 -0500)
commitebe5f51277db84b983963e513f02b2cd473dc196
treed074752bd531cca2e8c4ac914c9958d537d1ebe8
parent7e72a7dde5a73ed6177b321d29fca0df13f08f2c
Bug 29679: Remove redundant divider element from reports menu

The SQL report batch operations dropdown menu has divider list items
which add a border between sections (Bibliographic records, item
records, etc.). This element is redundant because the sections have
"headers" which also add a border.

This patch removes them.

To test, apply the patch and run an SQL report which will return results
that trigger the batch modification menu:

SELECT biblio.biblionumber , biblio.title, items.itemnumber,
items.itemcallnumber, items.barcode, borrowers.firstname,
borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber
FROM issues
LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber
LEFT JOIN items ON issues.itemnumber=items.itemnumber
LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber
ORDER BY RAND()

There should be no double border in the menu.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt