]> git.koha-community.org Git - koha.git/commit
Bug 22849: Do not share data (Mana) without agreement
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sat, 4 May 2019 16:33:34 +0000 (12:33 -0400)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 14 May 2019 18:06:17 +0000 (18:06 +0000)
commitf45fe692b14f45300456327bc74fd0a0872dff75
tree4299d135d9ad2aa1b13b82265a0e7835a3696afc
parent31684a426be4dcdf75a06f1f15fcfc73726fa6ae
Bug 22849: Do not share data (Mana) without agreement

A couple of things wrong in serials/subscription-add.pl

1.
447     if ( defined( $query->param('mana_id') ) ) {

It's always defined, you wanted to test with ""

2.
375     if ( (C4::Context->preference('Mana')) and ( grep { $_ eq "subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){

Mana == 2 == let me think about it
=> I am not expecting to reach Koha::SharedContent in that case

So we are sharing data whereas the library did not decide yet!

Test plan:
You need to be familiar you Mana to test this patch.

JD: I did not test this patch

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
serials/subscription-add.pl