]> git.koha-community.org Git - koha.git/commit
Bug 21593: Remove GROUP BY from GetAuthValueDropbox
authorNick Clemens <nick@bywatersolutions.com>
Thu, 18 Oct 2018 10:05:38 +0000 (10:05 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 26 Oct 2018 13:21:44 +0000 (14:21 +0100)
commitfa1846a7c17e33ef740ade83154d7347bf21cccd
treed11c878c53f0811ac2106a240b359e8e0501a5ec
parent8969eccaaeddfffbdc30a2f36e6dfc64595d607e
Bug 21593: Remove GROUP BY from GetAuthValueDropbox

With new MYSQL modes we are permitted only full group by.

In this case I don't think we need a GROUP BY at all

To test:
1 - Try to pay a fine or create a borrower
2 - Internal server error
3 - Apply patch
4 - Page should load
5 - Test various authorised values ot ensure they work
   e.g. Set bsort1 and bsort2 to have some authorised values with and
   without branch limits
   set PAYMENT_TYPE to have some values with and without branch limits

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 87c7e534f15aff14d6e82cbb67ecbb8e8715c2b7)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/Template/Plugin/AuthorisedValues.pm