From 23cbb6fb1ea34331498603a6470eb27a31b578ee Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Wed, 28 Dec 2022 22:39:43 +0000
Subject: [PATCH] Bug 32503: Fix date sorting for holds awaiting pickup tables

This patch is a little experimental, but seems to do the trick.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 208de0c37160c2dc055072b167d901525e7eb94f)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
---
 .../intranet-tmpl/prog/en/includes/waiting_holds.inc   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc
index d4007b3b7c..b08540f131 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc
@@ -5,12 +5,12 @@
     <thead>
         <tr>
             <th class="NoSort"><input type="checkbox" class="select_hold_all"/></th>
-            <th>Waiting since</th>
-            <th>Date hold placed</th>
+            <th data-type="@data-sort">Waiting since</th>
+            <th data-type="@data-sort">Date hold placed</th>
           [% IF table_name == 'holdscr' %]
-            <th>Date cancellation requested</th>
+            <th data-type="@data-sort">Date cancellation requested</th>
           [% END %]
-            <th>Expiration date</th>
+            <th data-type="@data-sort">Expiration date</th>
             <th class="anti-the">Title</th>
             <th>Patron</th>
             <th>Home library</th>
@@ -31,7 +31,7 @@
               [% IF table_name == 'holdscr' %]
                 <td>
                 [% FOREACH cancellation_request IN reserveloo.cancellation_requests %]
-                    <span>[% cancellation_request.creation_date | $KohaDates %]</span>
+                    <span data-order="[% cancellation_request.creation_date | html %]">[% cancellation_request.creation_date | $KohaDates %]</span>
                 [% END %]
                 </td>
               [% END %]
-- 
2.39.5