From 392ce9cbd57a916d94dc50487f4f71ee2eabfe08 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 8 Jun 2020 10:23:53 +0100 Subject: [PATCH] Bug 25526: Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit bbac95d9fbbcc0b586a7bc094f421c35a7d71011) Signed-off-by: Lucas Gass (cherry picked from commit 433fe0710043660404feb45b54ef5235974fa9a4) Signed-off-by: Aleisha Amohia --- members/paycollect.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/members/paycollect.pl b/members/paycollect.pl index b95a5708d5..b945d91587 100755 --- a/members/paycollect.pl +++ b/members/paycollect.pl @@ -42,7 +42,7 @@ my $writeoff_individual = $input->param('writeoff_individual'); my $change_given = $input->param('change_given'); my $type = scalar $input->param('type') || 'PAYMENT'; -my $updatecharges_permissions = ($writeoff_individual || $type eq 'writeoff') ? 'writeoff' : 'remaining_permissions'; +my $updatecharges_permissions = ($writeoff_individual || $type eq 'WRITEOFF') ? 'writeoff' : 'remaining_permissions'; my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { template_name => 'members/paycollect.tt', query => $input, @@ -165,7 +165,7 @@ if ( $total_paid and $total_paid ne '0.00' ) { error_over => 1, total_due => $total_due ); - } elsif ( $total_collected < $total_paid && !( $writeoff_individual || $type eq 'writeoff') ) { + } elsif ( $total_collected < $total_paid && !( $writeoff_individual || $type eq 'WRITEOFF' ) ) { $template->param( error_under => 1, total_paid => $total_paid -- 2.39.5