From 42e731857d53134f91ecf0099ae6b7c13393166c Mon Sep 17 00:00:00 2001 From: Mason James Date: Mon, 23 Mar 2015 14:30:26 +1300 Subject: [PATCH] Bug 13871: [TITLE_AMENDED] Additional changes The original perltidy patch from Mason has been amended. The perltidy itself has been moved to a separate patch with the current perltidyrc applied. As noted on Bugzilla, the original perltidy patch included some extra changes: [1] You prefix timestamp with Sip This is not actually needed (it is imported), but if we should prefix it, we should prefix now with C4::SIP::Sip. But you only changed two occurrences (out of 26). So I remove these two changes. [2] You remove the $server parameter from two calls of maybe_add: A closer look at the remaining code tells me that $server is always passed to maybe_add for FID_SCREEN_MSG. So this only left me the current whitespace change. But at least we documented what we did or did not, and why.. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan A Gallagher --- C4/SIP/Sip/MsgType.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm index 591db89cef..b0607df02f 100644 --- a/C4/SIP/Sip/MsgType.pm +++ b/C4/SIP/Sip/MsgType.pm @@ -427,7 +427,7 @@ sub build_patron_status { $resp .= maybe_add( FID_FEE_AMT, $patron->fee_amount ); } - $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg, $server ); + $resp .= maybe_add( FID_SCREEN_MSG, $patron->screen_msg, $server ); $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server ) if ( $server->{account}->{send_patron_home_library_in_af} ); -- 2.39.5