From cef24888bdf188857511136afd3d35ec607a0ca3 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 9 Aug 2018 12:32:49 -0300
Subject: [PATCH] Bug 13618: Escape HTML chars in checkouts.js

On the way the itemtype is not displaying correctly the description
instead of the code (in the relative's checkouts table)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 91 ++++++++++++++------
 1 file changed, 65 insertions(+), 26 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
index d6cd4b8fb4..b5edf4843f 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
@@ -219,11 +219,11 @@ $(document).ready(function() {
                         due = "<span id='date_due_" + oObj.itemnumber + "' class='date_due'>" + due + "</span>";
 
                         if ( oObj.lost ) {
-                            due += "<span class='lost'>" + oObj.lost + "</span>";
+                            due += "<span class='lost'>" + oObj.lost.escapeHtml() + "</span>";
                         }
 
                         if ( oObj.damaged ) {
-                            due += "<span class='dmg'>" + oObj.damaged + "</span>";
+                            due += "<span class='dmg'>" + oObj.damaged.escapeHtml() + "</span>";
                         }
 
                         var patron_note = " <span class='patron_note_" + oObj.itemnumber + "'></span>";
@@ -237,20 +237,20 @@ $(document).ready(function() {
                         title = "<span id='title_" + oObj.itemnumber + "' class='strong'><a href='/cgi-bin/koha/catalogue/detail.pl?biblionumber="
                               + oObj.biblionumber
                               + "'>"
-                              + oObj.title;
+                              + oObj.title.escapeHtml();
 
                         $.each(oObj.subtitle, function( index, value ) {
-                                  title += " " + value.subfield;
+                                  title += " " + value.subfield.escapeHtml();
                         });
 
                         if ( oObj.enumchron ) {
-                            title += " (" + oObj.enumchron + ")";
+                            title += " (" + oObj.enumchron.escapeHtml() + ")";
                         }
 
                         title += "</a></span>";
 
                         if ( oObj.author ) {
-                            title += " " + BY.replace( "_AUTHOR_",  " " + oObj.author );
+                            title += " " + BY.replace( "_AUTHOR_",  " " + oObj.author.escapeHtml() );
                         }
 
                         if ( oObj.itemnotes ) {
@@ -258,7 +258,7 @@ $(document).ready(function() {
                             if ( $.datepicker.formatDate('yy-mm-dd', new Date(oObj.issuedate) ) == ymd ) {
                                 span_class = "circ-hlt";
                             }
-                            title += " - <span class='" + span_class + " item-note-public'>" + oObj.itemnotes + "</span>";
+                            title += " - <span class='" + span_class + " item-note-public'>" + oObj.itemnotes.escapeHtml() + "</span>";
                         }
 
                         if ( oObj.itemnotes_nonpublic ) {
@@ -266,7 +266,7 @@ $(document).ready(function() {
                             if ( $.datepicker.formatDate('yy-mm-dd', new Date(oObj.issuedate) ) == ymd ) {
                                 span_class = "circ-hlt";
                             }
-                            title += " - <span class='" + span_class + " item-note-nonpublic'>" + oObj.itemnotes_nonpublic + "</span>";
+                            title += " - <span class='" + span_class + " item-note-nonpublic'>" + oObj.itemnotes_nonpublic.escapeHtml() + "</span>";
                         }
 
                         var onsite_checkout = '';
@@ -282,7 +282,7 @@ $(document).ready(function() {
                               + "#"
                               + oObj.itemnumber
                               + "'>"
-                              + oObj.barcode
+                              + oObj.barcode.escapeHtml()
                               + "</a>"
                               + onsite_checkout
 
@@ -290,12 +290,32 @@ $(document).ready(function() {
                     },
                     "sType": "anti-the"
                 },
-                { "mDataProp": "itemtype_description" },
-                { "mDataProp": "location" },
-                { "mDataProp": "homebranch" },
+                {
+                    "mDataProp": function ( oObj ) {
+                        return oObj.itemtype_description.escapeHtml();
+                    }
+                },
+                {
+                    "mDataProp": function ( oObj ) {
+                        return oObj.location.escapeHtml();
+                    }
+                },
+                {
+                    "mDataProp": function ( oObj ) {
+                        return oObj.homebranch.escapeHtml();
+                    }
+                },
                 { "mDataProp": "issuedate_formatted" },
-                { "mDataProp": "branchname" },
-                { "mDataProp": "itemcallnumber" },
+                {
+                    "mDataProp": function ( oObj ) {
+                        return oObj.branchname.escapeHtml();
+                    }
+                },
+                {
+                    "mDataProp": function ( oObj ) {
+                        return oObj.itemcallnumber.escapeHtml();
+                    }
+                },
                 {
                     "mDataProp": function ( oObj ) {
                         if ( ! oObj.charge ) oObj.charge = 0;
@@ -553,20 +573,20 @@ $(document).ready(function() {
                             title = "<span class='strong'><a href='/cgi-bin/koha/catalogue/detail.pl?biblionumber="
                                   + oObj.biblionumber
                                   + "'>"
-                                  + oObj.title;
+                                  + oObj.title.escapeHtml();
 
                             $.each(oObj.subtitle, function( index, value ) {
-                                      title += " " + value.subfield;
+                                      title += " " + value.subfield.escapeHtml();
                             });
 
                             if ( oObj.enumchron ) {
-                                title += " (" + oObj.enumchron + ")";
+                                title += " (" + oObj.enumchron.escapeHtml() + ")";
                             }
 
                             title += "</a></span>";
 
                             if ( oObj.author ) {
-                                title += " " + BY.replace( "_AUTHOR_", " " + oObj.author );
+                                title += " " + BY.replace( "_AUTHOR_", " " + oObj.author.escapeHtml() );
                             }
 
                             if ( oObj.itemnotes ) {
@@ -574,7 +594,7 @@ $(document).ready(function() {
                                 if ( $.datepicker.formatDate('yy-mm-dd', new Date(oObj.issuedate) ) == ymd ) {
                                     span_class = "circ-hlt";
                                 }
-                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes + "</span>"
+                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes.escapeHtml() + "</span>"
                             }
 
                             if ( oObj.itemnotes_nonpublic ) {
@@ -582,7 +602,7 @@ $(document).ready(function() {
                                 if ( $.datepicker.formatDate('yy-mm-dd', new Date(oObj.issuedate) ) == ymd ) {
                                     span_class = "circ-hlt";
                                 }
-                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes_nonpublic + "</span>"
+                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes_nonpublic.escapeHtml() + "</span>"
                             }
 
                             var onsite_checkout = '';
@@ -598,7 +618,7 @@ $(document).ready(function() {
                                   + "#"
                                   + oObj.itemnumber
                                   + "'>"
-                                  + oObj.barcode
+                                  + oObj.barcode.escapeHtml()
                                   + "</a>"
                                   + onsite_checkout;
 
@@ -606,11 +626,27 @@ $(document).ready(function() {
                         },
                         "sType": "anti-the"
                     },
-                    { "mDataProp": "itemtype" },
-                    { "mDataProp": "location" },
+                    {
+                        "mDataProp": function ( oObj ) {
+                            return oObj.itemtype_description.escapeHtml();
+                        }
+                    },
+                    {
+                        "mDataProp": function ( oObj ) {
+                            return oObj.location.escapeHtml();
+                        }
+                    },
                     { "mDataProp": "issuedate_formatted" },
-                    { "mDataProp": "branchname" },
-                    { "mDataProp": "itemcallnumber" },
+                    {
+                        "mDataProp": function ( oObj ) {
+                            return oObj.branchname.escapeHtml();
+                        }
+                    },
+                    {
+                        "mDataProp": function ( oObj ) {
+                            return oObj.itemcallnumber.escapeHtml();
+                        }
+                    },
                     {
                         "mDataProp": function ( oObj ) {
                             if ( ! oObj.charge ) oObj.charge = 0;
@@ -632,7 +668,10 @@ $(document).ready(function() {
                     {
                         "mDataProp": function( oObj ) {
                             return "<a href='/cgi-bin/koha/members/moremember.pl?borrowernumber=" + oObj.borrowernumber + "'>"
-                                 + oObj.borrower.firstname + " " + oObj.borrower.surname + " (" + oObj.borrower.cardnumber + ")</a>"
+                                + oObj.borrower.firstname.escapeHtml()
+                                + " " +
+                                oObj.borrower.surname.escapeHtml()
+                                + " (" + oObj.borrower.cardnumber.escapeHtml() + ")</a>"
                         }
                     },
                 ],
-- 
2.39.5