From d2a33f2eebbe2f41c84b272ad856fbcf8a68adfc Mon Sep 17 00:00:00 2001 From: Christopher Brannon Date: Thu, 13 Dec 2018 00:08:54 +0000 Subject: [PATCH] Bug 21944: Test for Circulation.pm Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- t/db_dependent/Circulation.t | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 8bf9e56aff..7c4c84b2c8 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -2595,7 +2595,7 @@ subtest '_FixAccountForLostAndReturned returns undef if patron is deleted' => su }; subtest 'Set waiting flag' => sub { - plan tests => 4; + plan tests => 9; my $library_1 = $builder->build( { source => 'Branch' } ); my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } ); @@ -2632,6 +2632,17 @@ subtest 'Set waiting flag' => sub { is( $hold->found, 'W', 'Hold is waiting' ); ( $status ) = CheckReserves($item->{itemnumber}); is( $status, 'Waiting', 'Now the hold is waiting'); + + #Bug 21944 - Waiting transfer checked in at branch other than pickup location + set_userenv( $library_1 ); + (undef, my $messages, undef, undef ) = AddReturn ( $item->{barcode}, $library_1->{branchcode} ); + $hold = Koha::Holds->find( $reserve_id ); + is( $hold->found, undef, 'Hold is no longer marked waiting' ); + is( $hold->priority, 1, "Hold is now priority one again"); + is( $messages->{ResFound}->{ResFound}, "Reserved", "Hold is still returned"); + is( $messages->{ResFound}->{found}, undef, "Hold is no longer marked found in return message"); + is( $messages->{ResFound}->{priority}, 1, "Hold is priority 1 in return message"); + }; subtest 'Cancel transfers on lost items' => sub { -- 2.39.5