From ffbaf8e2d73e6a383ae55b4eae2da756ee24a76d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 11 Oct 2011 15:56:10 -0400 Subject: [PATCH] Fix for Bug 7006, highlight patron changes in email This patch eliminates all unchanged fields from the email on the assumption that the information is superfluous. I have also added a link to the patron edit screen which will be displayed if the staffClientBaseURL has been entered. Signed-off-by: Chris Cormack Signed-off-by: Paul Poulain --- opac/opac-userupdate.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/opac/opac-userupdate.pl b/opac/opac-userupdate.pl index 86e562af09..297d5be26a 100755 --- a/opac/opac-userupdate.pl +++ b/opac/opac-userupdate.pl @@ -89,10 +89,9 @@ if ( $query->param('modify') ) { # get all the fields: my $message = <<"EOF"; -Patron $borr->{'cardnumber'} +Patron $borr->{'cardnumber'} has requested to change her/his personal details. +Please check these new details and make the changes to these fields: -has requested to change her/his personal details. -Please check these new details and make the changes: EOF my $streetnumber = $borr->{'streetnumber'} || ''; @@ -113,12 +112,13 @@ EOF $borrowerfield = format_date( $borr->{'dateofbirth'} ) || ''; } - if($borrowerfield eq $newfield) { - $message .= "$field : $borrowerfield --> $newfield\n"; - } else { - $message .= uc($field) . " : $borrowerfield --> $newfield\n"; + if($borrowerfield ne $newfield) { + $message .= $field . " : $borrowerfield --> $newfield\n"; } } + + $message .= "\nEdit this patron's record: http://".C4::Context->preference('staffClientBaseURL ')."/cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=".$borr->{'borrowernumber'}."&categorycode=".$borr->{'categorycode'} if C4::Context->preference('staffClientBaseURL '); + $message .= "\n\nThanks,\nKoha\n\n"; my %mail = ( To => $updateemailaddress, -- 2.39.5