]> git.koha-community.org Git - koha.git/commit
Bug 18664: Make IssueSlip returns if params are not valid
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 23 May 2017 19:33:17 +0000 (16:33 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 29 May 2017 02:26:23 +0000 (22:26 -0400)
commit59b58513fe4370e69fd3edb69a9976f4bc41a796
tree938d9b1f8c58387e43a9cbc036f9ab3f880ac8c3
parenta80366439e13fe3682d815c910d2efd7adafe840
Bug 18664: Make IssueSlip returns if params are not valid

Problem raised by bug 17762: IssueSlip should return if the params are
not valid.
The tests contain 2 FIXME to highlight this problem already, it's time
to fix them.

Note that, theoretically, this change may produce software error. Indeed
the caller expecting a hashref (letter) will access the "content" key.
But that should not happen.

Test plan:
Tests must return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Members.pm
t/db_dependent/Members/IssueSlip.t