]> git.koha-community.org Git - koha.git/commit
Bug 10595: don't display OpacTopissue page when system preference is turned off
authorMirko Tietgen <mirko@abunchofthings.net>
Tue, 16 Jul 2013 19:51:01 +0000 (21:51 +0200)
committerBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Fri, 13 Sep 2013 20:54:37 +0000 (17:54 -0300)
commitd92e6c746de1060a34631f4a0eea7bc71b110cd8
tree97f35ffd9c946b2b14141c1c9070f3c69c565ede
parent99706d790038e6bc0ea230f803946cd41845ddaa
Bug 10595: don't display OpacTopissue page when system preference is turned off

When the syspref is turned off, the link is hidden but the page is still
accessible. This patch checks the syspref and redirects to 404 if it is disabled.

Test plan:

Before applying the patch

Enable OpacTopissue
  Observe there is a link to opac-topissues.pl next to Advanced search etc.
  Follow that link, observe that opac-topissues.pl is loading
Disable OpacTopissue
  Observe the link is gone
  Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled

Apply patch

(OpacTopissue still diabled)
Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page.
Enable OpacTopissue
  Follow the link or manuall open opac-topissues.pl and check that it is working

Signoff the patch.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 04ca81bc358f1bc6425e1cef431d9e4abfc744d8)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works as expected
(cherry picked from commit 094bfd0d17689c92a4e9366af63ffb7fcbe99399)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit 094bfd0d17689c92a4e9366af63ffb7fcbe99399)
opac/opac-topissues.pl