]> git.koha-community.org Git - koha.git/commit
Bug 11795 - Use validation plugin when creating new Z39.50 server
authorOwen Leonard <oleonard@myacpl.org>
Wed, 19 Feb 2014 18:05:19 +0000 (13:05 -0500)
committerGalen Charlton <gmc@esilibrary.com>
Thu, 20 Feb 2014 16:58:11 +0000 (16:58 +0000)
commit19bf1e9a40ab5a8f3c86fb07dd6429bfc44f703b
tree9a45f0ceabce132708aa0fe1a1d99ea9a209eadb
parent4e9b5110d90c3ac60c61f710ff5892b9720e643e
Bug 11795 - Use validation plugin when creating new Z39.50 server

The page for adding a new Z39.50 server includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.

To test, apply the patch and go to Administration -> Z39.50 client
targets -> New Z39.50 server. Try submitting the form with any of the
following error conditions:

- Missing Z39.50 server name
- Missing hostname
- Missing port
- Non-numeric port
- Missing database
- Non-numeric rank
- Non-numeric timeout

These errors should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing
an existing Z39.50 server should also work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: replace tabs with spaces

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt