]> git.koha-community.org Git - koha.git/commit
Bug 14256: (follow-up) Check for unique constraint to regenerate random data
authorJonathan Druart <jonathan.druart@koha-community.org>
Thu, 4 Jun 2015 09:35:15 +0000 (11:35 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 10 Jun 2015 15:47:07 +0000 (12:47 -0300)
commitc5bc51d7d1b6c98e9d897022f91d8e0806cf4524
treea771d7ab0551ee94fbbdcbd66ae7a132987710d2
parent395304d3b58d79bb1306c4e6f799548e2d875356
Bug 14256: (follow-up) Check for unique constraint to regenerate random data

There were some issues in the previous patch. This patch fixes the
following:
- rename $value with $original_value
- remove $at_least_one_constraint_failed and $values_ok which make the
  code unnecessarily complicated
- the constraints have to be checked only if no original value is passed
- _buildColumnValue created a key to the default value hashref, it broke
  the test:
    last BUILD_VALUE if exists( $default_value->{$source} );

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
t/lib/TestBuilder.pm