]> git.koha-community.org Git - koha.git/commit
Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm
authorroot <root@kenza-VirtualBox>
Thu, 25 Jul 2013 12:03:32 +0000 (14:03 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 16 Aug 2013 15:14:32 +0000 (12:14 -0300)
commitcfb48010ad23e50fc93d893963164a17d4208c7b
treed8b472045d95e6a0887bbd9933eec1fe66b87d2b
parenta37558cd6087a1945611161b09e923f79b60d6e1
Bug 10643: fix inappropriate uses of $sth->finish() in C4::ClassSource.pm

This patch gets rid of finish() and replace prepare_cached by prepare.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 5cba6457aa00f3f3b2038f70057df300d9c6b9c3)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/ClassSource.pm