From 4a9c83d8508110f9d4e5a9dea5a34332831d85f3 Mon Sep 17 00:00:00 2001 From: Indranil Das Gupta Date: Thu, 14 May 2015 07:23:16 +0530 Subject: [PATCH] Bug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl This is a followup for Bug 14186 that removes the extraneous tab char on line 470, so that the patch can clear QA tools. This patch sets $reservedfor to an empty string. Test plan ========= 1/ in a terminal, run `tail -f ` on your instance's opac-error.log 2/ go to the opac and search from an item that exists on the Koha instance. 3/ Select the title (if more than one title is returned) and click on 'Place hold' link to go to opac-reserve.pl 4/ notice the warning - "opac-reserve.pl: Use of uninitialized value $reservedfor" appear in the `tail`ed opac-error.log 5/ apply the patch 6/ reload the page (opac-reserve.pl) 7/ page works but the warning in step #4 is no longer thrown up 8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error Remarks: Testing result match expected test plan output. The QA tests pass with "OK" for the commit. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 642e6012cd125cbc3aeaca83e1fd2430ce43fdb0) Signed-off-by: Chris Cormack --- opac/opac-reserve.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl index 9e9a4a0e74..eac5b94202 100755 --- a/opac/opac-reserve.pl +++ b/opac/opac-reserve.pl @@ -467,7 +467,7 @@ foreach my $biblioNum (@biblionumbers) { # the item could be reserved for this borrower vi a host record, flag this $reservedfor //= ''; - if ($reservedfor eq $borrowernumber){ + if ($reservedfor eq $borrowernumber){ $itemLoopIter->{already_reserved} = 1; } -- 2.39.5