From 5094909140081b02c9688faa07fc630feab91f24 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 20 Jul 2018 11:21:11 +0200 Subject: [PATCH] Bug 20811: (QA follow-up) Make the isbn check work The following code was never reached, since $isbn was not filled. if (!$biblionumber && $isbn_check && $isbn) { $sth_isbn->execute($isbn); ($biblionumber,$biblioitemnumber) = $sth_isbn->fetchrow; } Solution: Fix the code with two $isbn declarations. Move the checkisbn condition a level deeper. Test plan: Run misc/migration_tools/bulkmarcimport.pl -file bib726.utf8 --update -isbn Since you do not match on biblionumber, the ISBN should match. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit a49a7f08d6dbaf992d70420dae744c75c2ad8aae) Signed-off-by: Martin Renvoize --- misc/migration_tools/bulkmarcimport.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index 46c501758a..765f03a1a2 100755 --- a/misc/migration_tools/bulkmarcimport.pl +++ b/misc/migration_tools/bulkmarcimport.pl @@ -296,11 +296,11 @@ RECORD: while ( ) { &$localcust($record) if $localcust; my $isbn; # remove trailing - in isbn (only for biblios, of course) - if ($biblios && $cleanisbn) { + if( $biblios ) { my $tag = $marcFlavour eq 'UNIMARC' ? '010' : '020'; my $field = $record->field($tag); - my $isbn = $field && $field->subfield('a'); - if ( $isbn ) { + $isbn = $field && $field->subfield('a'); + if ( $isbn && $cleanisbn ) { $isbn =~ s/-//g; $field->update('a' => $isbn); } -- 2.39.5