From f1b0dae9a6055e8ba5e9a9638af32060c1e17e33 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 1 Sep 2017 08:41:51 -0400 Subject: [PATCH] Bug 18946 [QA Followup] - code cleanup Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart --- opac/opac-changelanguage.pl | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/opac/opac-changelanguage.pl b/opac/opac-changelanguage.pl index 689f4d4307..133e58efdb 100755 --- a/opac/opac-changelanguage.pl +++ b/opac/opac-changelanguage.pl @@ -15,17 +15,20 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; + use C4::Templates; use CGI qw ( -utf8 ); my $query = new CGI; my $language = $query->param('language'); + # Detect where the user came from and save that url -my $requestedUrl = $query->url(-base => 1) ; +my $requestedUrl = $query->url( -base => 1 ); + # Use referer url if it matches $requestedUrl else use $requestedUrl as the url . -my $url = $query->referer()=~$requestedUrl ? $query->referer() : $requestedUrl; +my $url = + $query->referer() =~ $requestedUrl ? $query->referer() : $requestedUrl; # warn "Language : $query // $language // $url"; @@ -33,6 +36,6 @@ my $url = $query->referer()=~$requestedUrl ? $query->referer() : $requestedUrl # 'language=' should be removed from url string, otherwise # the language picker will not work $url =~ s|(.)language=[\w-]*&?|$1|; -$url =~ s|(&\|\?)$||; # Remove extraneous ? or & +$url =~ s|(&\|\?)$||; # Remove extraneous ? or & C4::Templates::setlanguagecookie( $query, $language, $url ); -- 2.39.5