]> git.koha-community.org Git - koha.git/commit
Bug 36909: Eliminate duplicate ID in cookie consent markup
authorOwen Leonard <oleonard@myacpl.org>
Tue, 21 May 2024 14:47:21 +0000 (14:47 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 19 Jul 2024 15:34:35 +0000 (15:34 +0000)
commit1ad2dd1a6a6d1d52bfbd421b72a5dbfa30951cc3
treecb0acd8f40337ff63fac91dcdf9f3f930fd6c908
parent84814bbef33ac9c04b12cb3f063b2a11cfd0b2ce
Bug 36909: Eliminate duplicate ID in cookie consent markup

This patch changes markup and CSS in the OPAC and staff client to
eliminate HTML validator warnings about duplicate ids.

To test, apply the patch and rebuild all CSS (Bug 36909: Eliminate
duplicate ID in cookie consent markup).

- If necessary, set the "CookieConsent" system preference to "Require."
- Open the OPAC in a new private window (to prevent previous consents
  from hiding the consent messages).
- You should see a cookie consent bar across the bottom of the page. It
  should look correct, and its contents should reflow well at various
  browser widths.
- Click "Accept all cookies."
- In the header you should now see a "Your cookies" link.
- Click it and confirm that the contents of the modal look correct and
  reflow well at various browser widths.

- Perform the same tests in the staff interface.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 984960351ec23994d87642ec1b077e7577ca5659)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc
koha-tmpl/opac-tmpl/bootstrap/css/src/_responsive.scss
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc