]> git.koha-community.org Git - koha.git/commit
Bug 34666: Allow item_group to be null and still match
authorNick Clemens <nick@bywatersolutions.com>
Wed, 30 Aug 2023 18:38:56 +0000 (18:38 +0000)
committerMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Fri, 15 Sep 2023 10:08:27 +0000 (10:08 +0000)
commit3f3d38f6e6b13734d3ec811e60834ee92abb988e
tree0c2de93ccc29666fd6519999df39d47337bb0ebc
parentcf3153aec411b2db168ee3a328937456a9d4a0a3
Bug 34666: Allow item_group to be null and still match

The current logic requires that the grop ids match, but this eliminates null matches
from the group.

The fallout essentially is that the queue won't be checked to fill holds in cases of title level matches
where holds don't have an item group id. The queue checks the transport cost matrix while the check reserves
check does not, so this may have an impact on holds costs and delivery times

To test:
0 - Apply unit test patch
1 - prove -v t/db_dependent/Reserves.t
2 - It fails
3 - Apply this patch
4 - prove -v t/db_dependent/Reserves.t
5 - It passes!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit fe3872f62885b4b0ee483e446c0b2b85e74970f7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit f4641ea97228966cc5b7a54e1bfda2778b4d1a3b)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
C4/Reserves.pm