]> git.koha-community.org Git - koha.git/commit
Bug 34180: Template variable in JavaScript prevents authority MARC preview from displ...
authorOwen Leonard <oleonard@myacpl.org>
Wed, 16 Nov 2022 12:10:16 +0000 (12:10 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 3 Jul 2023 17:51:45 +0000 (14:51 -0300)
commit6d433ffa8931487c967ec01c483e9bb13eb5700b
tree8938cb9d8a7887863e3111301703b1ff5e632f40
parentc7be8462436350841c0b3715f007f2000e1735f5
Bug 34180: Template variable in JavaScript prevents authority MARC preview from displaying

Since template variables cannot be processed by JS, we must use a
template to declare a JS variable which the JS file can used. This patch
corrects this problem in the JS file which handles display of the
authority MARC preview from the authority search results page.

To test, apply the patch and go to Authorities.

- Perform a search which will return multiple authority results.
- Click "Actions -> MARC preview." The preview should display correctly.
- Click "Actions -> MARC preview" on another search result. This preview
  should also look correct.
- There should be no JavaScript errors in the browser console.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/includes/authorities_js.inc
koha-tmpl/intranet-tmpl/prog/js/authorities-detail-modal.js