]> git.koha-community.org Git - koha.git/commit
Bug 18694: Translatability: Get rid of exposing [%% FOREACH in csv/cash_register_stats.tt
authorMarc Véron <veron@veron.ch>
Tue, 30 May 2017 06:41:53 +0000 (08:41 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 12 Jun 2017 20:56:38 +0000 (17:56 -0300)
commitec478e18f352d340c7a1ec4416121928229c2907
tree56bb9dbad28a1fc7c59bc43d8475f633273f6faf
parent855ff0fb9a1cf7755a0805910c367150b37b5f2a
Bug 18694: Translatability: Get rid of exposing [%% FOREACH in csv/cash_register_stats.tt

Code exposed is:
%s %s %s [%%- FOREACH field IN row; field IF !loop.last; ItemTypes.GetDescription(field) IF loop.last; sep IF !loop.last; END %%] %s TOTAL [%%- FOREACH field IN total; field; sep IF !loop.last; END %%]

Similar for: csv/orders_by_budget.tt

To test:
- Apply patch
- In staff client, verify that Cash register statistics work as before
  (Home > Reports > Cash register statistics)
- Verify the same for Home > Reports > Orders by fund (triggers orders_by_budget.tt)
- Bonus test: Create a "language" aa-AA (perl translate create aa-AA
  from folder misc/translator, verify that lines mentioned above do
  no longer appear in aa-AA-staff-prog.po )
- Run QA tools (newest version with test for newlines in tt directives)

Rebased on top of Bug 18734 2017-12-06 / mv

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/reports/csv/cash_register_stats.tt
koha-tmpl/intranet-tmpl/prog/en/modules/reports/csv/orders_by_budget.tt