From 0059e97defef52f10dddb75588b80b9005749160 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 1 Oct 2024 14:05:56 +0000 Subject: [PATCH] Bug 37810: (QA follow-up) Tidy Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize --- .../Koha/ERM/EUsage/UsageDataProvider.t | 46 +++++++++++++------ 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t index 3f64e0e1d3..941bfe351d 100755 --- a/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t +++ b/t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t @@ -118,29 +118,45 @@ subtest 'test_connection() tests' => sub { $schema->storage->txn_begin; my $ua = Test::MockModule->new('LWP::UserAgent'); - $ua->mock('simple_request', sub { + $ua->mock( + 'simple_request', + sub { my $response = Test::MockObject->new(); - $response->mock('code', sub { - return 200; - }); - $response->mock('is_error', sub { - return 0; - }); - $response->mock('is_redirect', sub { - return 0; - }); - $response->mock('decoded_content', sub { - return '{"Description":"COUNTER Usage Reports for Test platform.","ServiceActive":true,"RegistryURL":"https://www.whatever.com"}'; - }); + $response->mock( + 'code', + sub { + return 200; + } + ); + $response->mock( + 'is_error', + sub { + return 0; + } + ); + $response->mock( + 'is_redirect', + sub { + return 0; + } + ); + $response->mock( + 'decoded_content', + sub { + return + '{"Description":"COUNTER Usage Reports for Test platform.","ServiceActive":true,"RegistryURL":"https://www.whatever.com"}'; + } + ); $response->{_rc} = 200; return $response; - }); + } + ); my $usage_data_provider = $builder->build_object( { class => 'Koha::ERM::EUsage::UsageDataProviders', value => { name => 'TestProvider' } } ); - is( $usage_data_provider->test_connection, 1); + is( $usage_data_provider->test_connection, 1 ); $schema->storage->txn_rollback; }; -- 2.39.5