From 32e5fa26e4965a425cd6ed96cb591e1a2164fe6b Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 18 Jan 2023 13:12:08 +0000
Subject: [PATCH] Bug 32634: (follow-up) Restructure page headings

An error in template logic is preventing the page's h1 from displaying.
Rather than fixing this I have changed the h1 to display a generic
"Transaction details" h1. The h2 shows the transaction type (credit or
debit).

The h2 is now inside the .page-section.

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Checked all the places mentioned in the commit message, and they
all have .page-section now.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../en/modules/members/accountline-details.tt | 22 +++++++------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
index 3e4aea526f..067b868dbe 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
@@ -63,25 +63,19 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
 
-            <h1>
-                [% IF type == 'credit' %]
-                    <span>Details of payment</span>
-                [% ELSIF type == 'debit' %]
-                    <span>Details of fee</span>
-                [% END %]
-            </h1>
-
             [% INCLUDE 'members-toolbar.inc' borrowernumber=patron.borrowernumber %]
 
+            <h1>Transaction details</h1>
+
             [% IF accountline %]
-                [% af_values = accountline.additional_field_values %]
-                [% IF accountline.credit_type_code %]
-                    <h2>Details of credit</h2>
-                [% ELSIF accountline.debit_type_code %]
-                    <h2>Details of debit</h2>
-                [% END %]
 
                 <div class="page-section">
+                    [% af_values = accountline.additional_field_values %]
+                    [% IF accountline.credit_type_code %]
+                        <h2>Details of credit</h2>
+                    [% ELSIF accountline.debit_type_code %]
+                        <h2>Details of debit</h2>
+                    [% END %]
 
                     <table id="table_account_fines">
                         <thead>
-- 
2.39.5