From 4ec526d48584393b5b62fe959fc4c22177c21973 Mon Sep 17 00:00:00 2001 From: David Cook Date: Mon, 11 Feb 2013 16:24:20 +1100 Subject: [PATCH] Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail There is just a small typo where one of the results of a conditional is "subscription" rather than "subscriptions". If this comes up, the correct tab (subscriptions) will not be chosen. I'm not sure what will happen...it'll probably just have the "holdings", "subscriptions", and "serial collection" tabs all default to closed with none of them being open. Test Plan: The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". Any tests other than that would be overly complex for such a trivial patch. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack --- opac/opac-detail.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 7c28c261a9..6f32841e7e 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -958,7 +958,7 @@ my $defaulttab = $subscriptionsnumber ? 'subscriptions' : @serialcollections > 0 - ? 'serialcollection' : 'subscription'; + ? 'serialcollection' : 'subscriptions'; $template->param('defaulttab' => $defaulttab); if (C4::Context->preference('OPACLocalCoverImages') == 1) { -- 2.39.5