From 74bda07f03620cfbc3e1eb15e664561343d9c1f4 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 19 Dec 2023 11:45:59 +0100
Subject: [PATCH] Bug 35600: Prevent checkouts table to flicker

The checkouts table is displayed in the DOM then hidden in JS, then we show it if the cookie is set.

This patch makes the table hidden by default, and show it if/when needed

Test plan:
Check an item out, see the checkouts list view
Play with "Always show checkouts automatically", refresh the page
=> UI should behave better than before this patch

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 6c8beb2f2ed566dc2e6645d99f2ef0e80eaf726b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 703ee190d94326538d8121563e5dee76aa5b2950)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc | 4 ++--
 koha-tmpl/intranet-tmpl/prog/js/checkouts.js                 | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
index f4343e0791..8374748c81 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
@@ -9,7 +9,7 @@
         </p>
     </div>
     <form name="issues" action="/cgi-bin/koha/tools/export.pl" method="post">
-        <table id="issues-table" style="width: 100% !Important;">
+        <table id="issues-table" style="width: 100% !Important; display: none;">
             <thead>
                 <tr>
                     <th scope="col">&nbsp;</th>
@@ -42,7 +42,7 @@
         <label for="issues-table-load-immediately">Always show checkouts automatically</label>
         <input id="issues-table-load-immediately" type="checkbox" />
 
-        <div id="issues-table-actions">
+        <div id="issues-table-actions" style="display: none;">
             <fieldset class="action">
                 [% IF ( CAN_user_circulate_override_renewals ) %]
                     [% IF Koha.Preference( 'AllowRenewalLimitOverride' ) || Koha.Preference( 'AllowRenewalOnHoldOverride' ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
index d5237792c7..4707ec6dbe 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
@@ -243,8 +243,6 @@ $(document).ready(function() {
 
     var ymd = flatpickr.formatDate(new Date(), "Y-m-d");
 
-    $('#issues-table').hide();
-    $('#issues-table-actions').hide();
     $('#issues-table-load-immediately').change(function(){
         if ( this.checked && typeof issuesTable === 'undefined') {
             $('#issues-table-load-now-button').click();
-- 
2.39.5