From b9a150cae7004078d0d637f0740e7796cdbf4224 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Fri, 1 Mar 2024 08:02:47 +0000
Subject: [PATCH] Bug 36206: Expose administration page to users with
 plugins_admin permission

This patch updates the intranet home page logic such that the
administration button appears for those users with just the 'admin'
subpermission of plugins to allow them to access such plugins.

We also update the display logic found inside the admin-home page so
that user see plugin management appropriately.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../intranet-tmpl/prog/en/modules/admin/admin-home.tt  | 10 ++++++----
 .../intranet-tmpl/prog/en/modules/intranet-main.tt     |  2 +-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
index 4c215d27fb..d833bf3a51 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
@@ -148,17 +148,19 @@
                 </dl>
             [% END %]
 
-            [% IF CAN_user_plugins && plugins_enabled %]
+            [% IF plugins_enabled %]
                 <h3>Plugins</h3>
                 <dl>
+                [% IF CAN_user_plugins_manage || CAN_user_plugins_configure %]
                     <dt><a href="/cgi-bin/koha/plugins/plugins-home.pl">Manage plugins</a></dt>
                     <dd>View, manage, configure and run plugins.</dd>
-                    [% IF ( CAN_user_plugins_admin && admin_plugins ) %]
-                        [% FOREACH plugin IN admin_plugins %]
+                [% END %]
+                [% IF ( CAN_user_plugins_admin && admin_plugins ) %]
+                    [% FOREACH plugin IN admin_plugins %]
                         <dt><a href="/cgi-bin/koha/plugins/run.pl?class=[% plugin.class | uri %]&method=admin"><span class="plugin_name">[% plugin.metadata.name | html %]</span></a></dt>
                         <dd>[% plugin.metadata.description | html %]</dd>
-                        [% END %]
                     [% END %]
+                [% END %]
                 </dl>
             [% END %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
index 856d9fb0c3..70da106b61 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
@@ -165,7 +165,7 @@
                             </li>
                             [% END %]
 
-                            [% IF ( CAN_user_parameters ) %]
+                            [% IF ( CAN_user_parameters || CAN_user_plugins_admin ) %]
                             <li>
                                 <a class="icon_general icon_administration" href="/cgi-bin/koha/admin/admin-home.pl"><i class="fa fa-fw fa-gears"></i>Koha administration</a>
                             </li>
-- 
2.39.5