From db37dbf8b842023e0fc0462d0cc2e582e56f343c Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Wed, 23 Aug 2023 15:24:49 +0000 Subject: [PATCH] Bug 33716: (QA follow-up) Fix submission when cardnumber is invalid Issue that this patch fixes: 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Copy the example YAML text into the system preference input box 3) Create a new FreeForm request and enter a duff borrowernumber e.g. '11111111111111' 4) Click 'Create'. Submit the type disclaimer stage. 5) Notice there's an error 6) Apply this patch. 7) Repeat steps 3 and 4. Verify that the correct 'The borrower details you entered are invalid' error message is displayed instead of the error in 5). Signed-off-by: Tomas Cohen Arazi --- ill/ill-requests.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl index 8a4daf74cb..f8a385f30a 100755 --- a/ill/ill-requests.pl +++ b/ill/ill-requests.pl @@ -133,7 +133,7 @@ if ( $backends_available ) { my $backend_result = $request->backend_create($params); # After creation actions - if ( $params->{type_disclaimer_submitted} ) { + if ( $params->{type_disclaimer_submitted} && $request->illrequest_id ) { $type_disclaimer->after_request_created($params, $request); } -- 2.39.5