From eac29685b98ee766a861bd664fe1fc5b15d417d0 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 3 Jul 2017 09:31:52 +0200 Subject: [PATCH] Bug 18881: [QA Follow-up] Remove even more Removing the commented section from the template: If it does not work, it should not be here. When it works again, put it back in. Since @itemtypesloop is not used, remove it from the script too. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit e48a5fb560123bac31e9a692026601ddd320f966) Signed-off-by: Fridolin Somers --- circ/view_holdsqueue.pl | 13 ------------- .../prog/en/modules/circ/view_holdsqueue.tt | 11 ----------- 2 files changed, 24 deletions(-) diff --git a/circ/view_holdsqueue.pl b/circ/view_holdsqueue.pl index 2792bd3016..3d8649aff1 100755 --- a/circ/view_holdsqueue.pl +++ b/circ/view_holdsqueue.pl @@ -62,19 +62,6 @@ if ( $run_report ) { ); } -# getting all itemtypes -my $itemtypes = Koha::ItemTypes->search({}, {order_by => 'itemtype'});; -my @itemtypesloop; -while ( my $itemtype = $itemtypes->next ) { - push @itemtypesloop, { - value => $itemtype->itemtype, - }; -} - -$template->param( # FIXME Could be improved passing the $itemtypes iterator directly to the template - itemtypeloop => \@itemtypesloop, -); - # Checking if there is a Fast Cataloging Framework $template->param( fast_cataloging => 1 ) if Koha::BiblioFrameworks->find( 'FA' ); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt index 509e5baf13..75411cc1b1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt @@ -209,17 +209,6 @@ $(document).ready(function() { [% PROCESS options_for_libraries libraries => Branches.all() %] -
-- 2.39.5